fix: (CXSPA-9504) support Chinese address in address book by espada945 · Pull Request #21272 · SAP/spartacus

espada945 · 2026-03-23T08:32:21Z

Summary

Add cascading city/district dropdowns when China is selected as country
Change "State" label to "Province" for Chinese addresses
Make cellphone required for Chinese addresses
Add district field for Chinese addresses

Test plan

Select China as country → verify city/district dropdowns and Province label
Add complete Chinese address → verify successful save
Switch to non-China country → verify form reverts to default

Add province/city/district fields for Chinese addresses, make cellphone required, and display Province instead of State label.

github-actions · 2026-03-24T03:33:14Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

cypress · 2026-03-24T05:06:09Z

spartacus Run #52719

Run Properties: Failed #52719 • 33fe26944f ℹ️: Merge 9e015424b2ba29f7c6c601e4634d3636d4f0a7f9 into 0daa1855b5a77ee72f8b3e68053c...

Project	`spartacus`
Branch Review	`bugfix/CXSPA-9504`
Run status	`Failed #52719`
Run duration	`04m 31s`
Commit	`33fe26944f ℹ️: Merge 9e015424b2ba29f7c6c601e4634d3636d4f0a7f9 into 0daa1855b5a77ee72f8b3e68053c...`
Committer	`espada945`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`3`
Pending	`0`
Skipped	`0`
Passing	`100`
View all changes introduced in this branch ↗︎

Tests for review

cypress/e2e/regression/variants/apparel-checkout-as-guest.core-e2e.cy.ts • 1 failed test • B2C

View Output Video

Test		Artifacts
Apparel - checkout as guest > Desktop > should perform checkout as guest, create an account and verify guest data		`Test Replay` `Video`

cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test		Artifacts
SSR > should render homepage		`Test Replay` `Video`
SSR > should render PLP		`Test Replay` `Video`
SSR > should render PDP		`Test Replay` `Video`

feature-libs/user/profile/components/address-book/address-form/address-form.component.ts

feature-libs/user/profile/components/address-book/address-form/address-form.component.html

feature-libs/user/profile/components/address-book/address-form/address-form.component.ts

feature-libs/user/profile/components/address-book/address-form/address-form.component.spec.ts

…pport - Use inject() for ChineseAddressService instead of modifying constructor - Rename isChinaAddress to isChineseAddress - Extract HTTP calls to ChineseAddressService with proper error handling and typed responses - Use OccEndpointsService.buildUrl() instead of hardcoded URLs - Reset selectedRegion$/selectedCity$ when switching away from CN - Reorder form fields: Province before City for Chinese address - Refresh cities/districts on language change via LanguageService - Skip address verification for Chinese addresses - Display city/district/region/country names instead of isocodes in address book - Add city and cityDistrict fields to Address model - Request FULL fields for address list API

Disable city dropdown until province is selected and district dropdown until city is selected for Chinese addresses. Show helpful placeholder text ("Please select a province/city first") when disabled.

- Add province/district/placeholder translations for zh and zh_TW - Refresh Chinese placeholders on language switch - Convert cities$/districts$ from observables to arrays with subscriptions - Fix spec tests to match new array properties - Fix prettier formatting in occ-user-address.adapter.ts

…y ternary

github-actions · 2026-03-31T06:01:44Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

…ider, prettier formatting - Add SiteAdapter mock provider to OpfCheckoutBillingAddressFormComponent spec (required after SiteConnector was added as UserAddressService dependency) - Fix prettier formatting in address-form.component.ts - Use address name instead of isocode for country and region in address card

i336588 · 2026-04-10T04:05:14Z

feature-libs/user/profile/components/address-book/address-form/address-form.component.ts

+    }
+  }
+
+  protected updateChinesePlaceholders(): void {}


This empty method is never used.

i336588 · 2026-04-10T05:55:17Z

projects/core/src/user/facade/user-address.service.ts

+  getCities(
+    regionIsocode: string
+  ): Observable<{ isocode?: string; name?: string }[]> {
+    return this.siteConnector.getCities(regionIsocode);


Using NgRx store pattern instead of direct API call would be better for consistency and performance, as getDeliveryCountries() and getRegions() already use.

Performance Issues with Current Implementation

Problem: Multiple API calls for same data
// In address-form.component.ts:194-218
combineLatest([this.selectedRegion$, this.languageService.getActive()])
.pipe(switchMap(([regionIsocode]) => {
return this.userAddressService.getCities(regionIsocode); // 🔴 API call every time!
}))

Every time language changes → new API call
User switches back to previous region → API call again
Multiple address forms on screen → duplicate API calls

Consistency with Existing Architecture

The codebase follows a clear pattern for location data:

Countries → Store (user/store/reducers/delivery-countries.reducer.ts)
Regions → Store (user/store/reducers/regions.reducer.ts)
Cities → Direct API ❌ (breaks pattern)
Districts → Direct API ❌ (breaks pattern)

…ider, prettier formatting - Add SiteAdapter mock provider to OpfCheckoutBillingAddressFormComponent spec - Add loadCities/loadDistricts to MockSiteAdapter in site.connector.spec.ts - Fix prettier formatting in address-form.component.ts - Display country/region name instead of isocode in address book card

… spec

github-actions · 2026-04-10T10:05:33Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

…ocode

github-actions · 2026-04-12T06:01:14Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

github-actions · 2026-04-12T07:00:29Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

github-actions · 2026-04-12T07:55:04Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

github-actions · 2026-04-12T11:27:54Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

github-actions · 2026-04-12T14:44:34Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

…checkout test (CXSPA-10758)

github-actions · 2026-04-12T15:40:06Z

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

…elated changes

fix: (CXSPA-9504) support Chinese address in address book

acf4b32

Add province/city/district fields for Chinese addresses, make cellphone required, and display Province instead of State label.

espada945 requested review from a team as code owners March 23, 2026 08:32

fix: (CXSPA-9504) update existing unit tests for new dependencies

5768599

github-actions bot marked this pull request as draft March 23, 2026 08:50

espada945 and others added 4 commits March 23, 2026 17:09

Merge branch 'develop' into bugfix/CXSPA-9504

1fa348c

fix: add unit tests for China address logic to meet coverage threshold

bb54f99

fix: format spec file with prettier

8a57374

Merge branch 'develop' into bugfix/CXSPA-9504

6055a54

espada945 marked this pull request as ready for review March 24, 2026 03:30

fix: add null fallback for async pipe in ng-select items

01fe95b

github-actions bot marked this pull request as draft March 24, 2026 03:36

espada945 marked this pull request as ready for review March 24, 2026 04:48

scarai-sap reviewed Mar 24, 2026

View reviewed changes

feature-libs/user/profile/components/address-book/address-form/address-form.component.ts Outdated Show resolved Hide resolved

scarai-sap reviewed Mar 24, 2026

View reviewed changes

i336588 reviewed Mar 24, 2026

View reviewed changes

github-actions bot marked this pull request as draft March 26, 2026 08:36

espada945 and others added 5 commits March 26, 2026 17:09

fix: (CXSPA-9504) disable city/district dropdowns until parent selected

a512114

Disable city dropdown until province is selected and district dropdown until city is selected for Chinese addresses. Show helpful placeholder text ("Please select a province/city first") when disabled.

fix: (CXSPA-9504) format address-form component with prettier

cb57b67

Merge branch 'develop' into bugfix/CXSPA-9504

17fb9be

fix: (CXSPA-9504) reduce complexity in getCardContent, fix unnecessar…

a823920

…y ternary

espada945 marked this pull request as ready for review March 31, 2026 05:43

fix: (CXSPA-9504) trigger CI retry

5915982

github-actions bot marked this pull request as draft March 31, 2026 06:11

espada945 marked this pull request as ready for review March 31, 2026 06:42

espada945 and others added 2 commits April 10, 2026 11:05

Merge branch 'develop' into bugfix/CXSPA-9504

c90a80b

i336588 reviewed Apr 10, 2026

View reviewed changes

espada945 added 2 commits April 10, 2026 14:26

fix: (CXSPA-9504) add SiteAdapter mock provider to UserAddressService…

e420c1d

… spec

espada945 marked this pull request as ready for review April 10, 2026 09:33

fix: (CXSPA-9504) update E2E test to expect region name instead of is…

bb21cd6

…ocode

github-actions bot marked this pull request as draft April 12, 2026 05:43

espada945 marked this pull request as ready for review April 12, 2026 06:00

Merge branch 'develop' into bugfix/CXSPA-9504

4b48b52

github-actions bot marked this pull request as draft April 12, 2026 06:01

espada945 marked this pull request as ready for review April 12, 2026 06:42

fix: (CXSPA-9504) trigger MC re-run

a1dde53

github-actions bot marked this pull request as draft April 12, 2026 10:51

espada945 marked this pull request as ready for review April 12, 2026 11:11

chore: (CXSPA-9504) trigger MC re-run

bb6b2aa

github-actions bot marked this pull request as draft April 12, 2026 14:18

espada945 marked this pull request as ready for review April 12, 2026 14:26

fix: (CXSPA-9504) skip JDK21 createAccountFromGuest in apparel guest …

9e01542

…checkout test (CXSPA-10758)

github-actions bot marked this pull request as draft April 12, 2026 15:09

espada945 marked this pull request as ready for review April 12, 2026 15:22

revert: (CXSPA-9504) revert E2E test modification, keep only ticket-r…

d538e5d

…elated changes

github-actions bot marked this pull request as draft April 12, 2026 16:07

Conversation

espada945 commented Mar 23, 2026

Summary

Test plan

Uh oh!

github-actions bot commented Mar 24, 2026

Merge Checks Failed

Uh oh!

cypress bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

spartacus Run #52719

Tests for review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2026

Merge Checks Failed

Uh oh!

i336588 Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

i336588 Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 10, 2026

Merge Checks Failed

Uh oh!

github-actions bot commented Apr 12, 2026

Merge Checks Failed

Uh oh!

github-actions bot commented Apr 12, 2026

Merge Checks Failed

Uh oh!

github-actions bot commented Apr 12, 2026

Merge Checks Failed

Uh oh!

github-actions bot commented Apr 12, 2026

Merge Checks Failed

Uh oh!

github-actions bot commented Apr 12, 2026

Merge Checks Failed

Uh oh!

github-actions bot commented Apr 12, 2026

Merge Checks Failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cypress bot commented Mar 24, 2026 •

edited

Loading